-
Notifications
You must be signed in to change notification settings - Fork 612
[Rule Tunings] AWS Route 53 Rules #5448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS Route53 Resolver Query Log Configuration Deleted - updated title - updated Description, FP and IG sections - reduced execution window - updated tags - added highlighted fields AWS Route53 Domain Transfer Lock Disabled - increased rule severity to high - corrected `event.provider` value in query - updated title - updated Description, FP and IG sections - reduced execution window - added highlighted fields - updated Mitre AWS Route53 Domain Transferred to Another Account - increased rule severity to high - corrected `event.provider` value in query - updated title - updated Description, FP and IG sections - reduced execution window - added highlighted fields - updated Mitre AWS Route53 Private Hosted Zone Associated With a VPC - increased rule severity to medium - corrected `event.provider` value in query - updated title - updated Description, FP and IG sections - reduced execution window - added highlighted fields - updated Mitre
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought: shifting low --> high with functionally only the lookback changed, does that make sense? Maybe medium? Your data provided looks like this should be rare, but just double checking.
@Mikaayenson I didn't change the severity based on my tuning, I changed it based on the behavior itself. Transferring a domain to another account is rare and should have always been higher severity. |
Pull Request
Issue link(s):
Summary - What I changed
AWS Route53 Domain Transfer Lock DisabledandAWS Route53 Domain Transferred to Another Accountwere not alertingas expected due to an error in theevent.providerfield:(route53.amazonaws.com vs route53domains.amazonaws.com). This has been adjusted and I updated the rules in our stack in order to fully test them. I will continue to monitor these rules in telemetry moving forward to see how they perform as we currently have no existing data for them due to this error.AWS Route53 Private Hosted Zone Associated With a VPCandAWS Route53 Resolver Query Log Configuration Deletedare performing well in telemetry, low volume as expected.AWS Route53 Domain Transfer Lock Disabled
event.providervalue in queryAWS Route53 Domain Transferred to Another Account
event.providervalue in queryAWS Route53 Private Hosted Zone Associated With a VPC
event.providervalue in queryAWS Route53 Resolver Query Log Configuration Deleted
How To Test
These scripts will trigger the other 2 rules as expected
Test data is in the stack for running the queries against.